Skip to content

Conversation

@DeathFishAtEase
Copy link
Collaborator

@DeathFishAtEase DeathFishAtEase commented Dec 21, 2025

For non-urgent documentation modifications, they should now be submitted through this dedicated Pull Request and will undergo weekly batch merging.

Documentation changes associated with other feature/bugfix pull requests should remain within their respective Pull Requests.

For example: If a Pull Request gets merged into the main branch without completing required documentation updates, the content should first be synchronized to this dedicated documentation branch. Subsequent corrections will then be made within this dedicated documentation Pull Request.


对于并不急需的文档修改现改为使用这个拉取请求进行提交,每周进行一次合并。

对于其他拉取请求中的文档修改则跟随其拉取请求。

例如某个拉取请求在合并前没有处理完毕文档问题,那么在它合并到主分支后,将内容更新到这个拉取请求所在的分支,然后在这个拉取请求所在的分支进行进一步更正

Summary by CodeRabbit

  • Documentation
    • Updated Chinese translations for improved clarity and accuracy
    • Added new Chinese translation entries for game features and bug fixes

✏️ Tip: You can customize this high-level summary in your review settings.

DeathFishAtEase and others added 30 commits July 13, 2025 22:09
Restore previous AirstrikeTargets default value and add migration notice for target eligibility checks as they only affect mod logic
FireUp.ResetInRetarget
allow to set display duration for BannerType
@DeathFishAtEase DeathFishAtEase self-assigned this Dec 21, 2025
@DeathFishAtEase DeathFishAtEase added the No Documentation Needed No documentation needed whatsoever label Dec 21, 2025
@github-actions
Copy link

github-actions bot commented Dec 21, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@coderabbitai
Copy link

coderabbitai bot commented Dec 26, 2025

📝 Walkthrough

Walkthrough

Chinese translation files are updated with refined terminology for game mechanics documentation and localization metadata. The AI-Scripting-and-Mapping translation for the OnlyTargetHouseEnemy tag is adjusted, and the CREDITS locale file is synced with metadata updates, cross-reference corrections, and new translation entries for recent game features.

Changes

Cohort / File(s) Change Summary
Translation refinement
docs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.po
Updated Chinese translation for OnlyTargetHouseEnemy tag description from "默认值,禁用强制" to "默认值,不强制更改" for clearer phrasing
Locale metadata & entries
docs/locale/zh_CN/LC_MESSAGES/CREDITS.po
POT-Creation-Date metadata updated (2025-12-21 → 2025-12-26); cross-reference line numbers adjusted throughout; three new translation blocks added for "Unit & infantry auto-conversion on ammo change", aircraft airport dock bugfix, and cloaked unit sensor requirements

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰✨ Translations hop along the path,
Where words dance in a new locale's bath,
Tags refined, and credits aligned,
Chinese whispers, beautifully signed! 📜

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context about the PR's purpose and includes guidance in both English and Chinese, but does not explicitly follow the repository's description template structure. Consider adding explicit sections or a clearer structure that aligns with the template guidance, particularly highlighting if documentation changes are present and confirming the target branch choice.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: a weekly batch of documentation revisions for the specified date range.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a82693b and 83d5626.

📒 Files selected for processing (4)
  • docs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.po
  • docs/locale/zh_CN/LC_MESSAGES/CREDITS.po
  • docs/locale/zh_CN/LC_MESSAGES/Fixed-or-Improved-Logics.po
  • docs/locale/zh_CN/LC_MESSAGES/Whats-New.po
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (5)
docs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.po (1)

1522-1522: LGTM! Translation clarity improvement.

The revised Chinese translation better conveys the intended meaning. Changing from "禁用强制" (disable forcing) to "不强制更改" (do not force changes) more accurately describes the default behavior where the global value for OnlyTargetHouseEnemy is not forcibly overridden.

docs/locale/zh_CN/LC_MESSAGES/CREDITS.po (4)

11-11: LGTM! Metadata update.

POT-Creation-Date updated to reflect the current documentation build timestamp.


609-609: LGTM! Clear and accurate translation.

The Chinese translation "基于弹药量的自动变形" accurately conveys "Unit & infantry auto-conversion on ammo change" - describing the feature where units automatically transform based on ammunition levels.


1937-1941: LGTM! Accurate bugfix description.

The translation correctly describes the AI aircraft production bug fix. The Chinese text clearly explains that the issue was AI attempting to produce aircraft even when no free docking spots were available at the airport.


2743-2747: LGTM! Clear sensor-related bugfix translation.

The translation accurately describes the fix where non-repairer units previously required sensors to attack cloaked friendly units. The Chinese "修复了非维修单位需要能够反隐才能攻击友军隐形单位的问题" clearly conveys this issue.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

allow `Harvester.CanGuardArea` to return harvest mission if there's no valid target around
customize AllowWeaponSelectAgainstWalls per techno & WeaponHelper tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Documentation Needed No documentation needed whatsoever

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants